Skip to content

test: update load balancer configuration instructions #3222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 2, 2022
Merged

Conversation

durran
Copy link
Member

@durran durran commented Apr 28, 2022

Description

Updates the test README's load balancer configuration instructions.

What is changing?

The load balancer config can no longer use mlaunch in the test script to work.

Is there new documentation needed for these changes?

None

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@@ -263,7 +263,29 @@ The following steps will walk you through how to create and test a MongoDB Serve

The following steps will walk you through how to start and test a load balancer.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a note about using a server 5.2.0 or above?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you add this note anywhere? @durran

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - forgot to push. It's there now.

Co-authored-by: Bailey Pearson <[email protected]>
@durran durran requested a review from baileympearson April 29, 2022 14:53
@baileympearson baileympearson changed the title test: update load balancer configuration test: update load balancer configuration instructions May 2, 2022
@baileympearson baileympearson merged commit e563d8c into main May 2, 2022
@baileympearson baileympearson deleted the lb-doc branch May 2, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants