Skip to content

test(NODE-4264): part 1 of removing connect from tests #3257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 28, 2022

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented May 19, 2022

Description

What is changing?

Removing connect usage from tests

NODE-4264
NODE-4327

Also removes three with client helpers:

  • withClient
  • withClientV2
  • withMonitoredClient

The files that made use of these helpers under went significant refactoring so there may be files that were edited to remove these helpers but not edited to remove connect.

What is the motivation for this change?

Simplifies tests, adds auto connect coverage

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken force-pushed the NODE-4192/remove-connect-testing branch 2 times, most recently from f64488b to 325865e Compare May 25, 2022 21:41
@nbbeeken nbbeeken force-pushed the NODE-4192/remove-connect-testing branch from 325865e to b90bcc9 Compare June 15, 2022 17:52
@nbbeeken nbbeeken force-pushed the NODE-4192/remove-connect-testing branch from 5e9561b to a0d4654 Compare June 22, 2022 19:53
@nbbeeken nbbeeken force-pushed the NODE-4192/remove-connect-testing branch from a0d4654 to f7027f0 Compare June 22, 2022 20:20
@nbbeeken nbbeeken requested a review from baileympearson June 23, 2022 17:49
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 23, 2022
@nbbeeken nbbeeken marked this pull request as ready for review June 23, 2022 17:49
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review pt 1

@nbbeeken nbbeeken requested a review from baileympearson June 27, 2022 16:28
@baileympearson baileympearson merged commit 78a55e2 into main Jun 28, 2022
@baileympearson baileympearson deleted the NODE-4192/remove-connect-testing branch June 28, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants