Skip to content

test: resumability for change stream unified tests #3282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

baileympearson
Copy link
Contributor

Description

What is changing?

This PR fixes resumabillity for change stream unified tests. It also deletes the legacy change stream tests, now that all the unified tests are running.

Is there new documentation needed for these changes?

No.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson
Copy link
Contributor Author

evergreen run

nbbeeken
nbbeeken previously approved these changes Jun 2, 2022
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM we talked about an improvement that would be nice here, optional

@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 2, 2022
nbbeeken
nbbeeken previously approved these changes Jun 3, 2022
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jun 3, 2022
@baileympearson baileympearson force-pushed the no-story-fix-resumability-unified-change-stream-tests branch from b17136f to e5fef5b Compare June 3, 2022 20:45
@nbbeeken nbbeeken changed the title fix: resumability for change stream unified tests test: resumability for change stream unified tests Jun 3, 2022
@nbbeeken nbbeeken merged commit c8362eb into main Jun 3, 2022
@nbbeeken nbbeeken deleted the no-story-fix-resumability-unified-change-stream-tests branch June 3, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants