refactor(NODE-4125): misc change stream improvements #3284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
changed the title
nbbeeken
added
the
Primary Review
nbbeeken
suggested changes
Jun 3, 2022
baileympearson
force-pushed
the
NODE-4125-misc-change-stream-cleanups
branch
from
bd8c314 to
e79db9b
Compare
Adds our custom overloads of Mocha's functions to the ExclusiveSuiteFunction interface in global.d.ts, so a describe.only doesn't cause everything to have type errors.
revert: change to doc comment
the _initialized and _needToClose variables were unnecessary. - _initialized existed only to conditionally set _needToClose when the stream was read from for the first time - _needToClose is unnecessary, because cursor.close is a no-op if the cursor is already closed.
baileympearson
force-pushed
the
NODE-4125-misc-change-stream-cleanups
branch
from
e79db9b to
7cdb01c
Compare
nbbeeken
previously approved these changes
Jun 10, 2022
nbbeeken
changed the title
nbbeeken
added
Team Review
nbbeeken
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changing?
As a part of NODE-4125, I made a couple of small refactors. NODE-4125 isn't done, but I broke these changes into a separate PR. I made 6 distinct changes:
.onlydescribe blocks to our mocha confignext<T>function, explaining what theblockingparameter doestryNextfunction on the change stream to be grouped with the other iterator methodsI think point 5 is probably the only change that will cause contention so I'm happy to revert if it we decide that's what we want to do.
Is there new documentation needed for these changes?
No.
What is the motivation for this change?
Improved driver code.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>