Skip to content

test(NODE-4316): sync latest cmap tests for pool pausing #3293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 22, 2022

Conversation

dariakp
Copy link
Contributor

@dariakp dariakp commented Jun 17, 2022

Description

NODE-4316
fully covers NODE-3254, NODE-3257, NODE-3259
as well as the test sync changes needed for NODE-3255 and NODE-2994

What is changing?

  • cmap spec tests are synced with latest
  • new pool pause tests are added and skipped
  • existing tests have ready operation added (currently no-op)
  • one existing test has backgroundThreadIntervalMS option added, the runner types were updated with this new option and the runner itself was updated to check pool options against the known list of options
  • another test had a ConnectionPoolReady event added to its list of expected events, which we cannot handle until pool pausing is implemented, so temporary logic was added to filter it out from the expected event list

Note to reviewers:

  • verify that existing cmap tests run and pass as before on all configurations of interest (i.e., server, rs, sharded, and lb) and the newly added tests appear in the logs with the expected skip reason
  • implementation of handling for appName and timeout in waitForEvent test options is intentionally deferred to NODE-2994 since no running tests currently use them
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Have tests readily available for the core work of pool pausing

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@dariakp dariakp marked this pull request as ready for review June 17, 2022 18:46
@baileympearson baileympearson self-requested a review June 21, 2022 17:52
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 21, 2022
@baileympearson baileympearson added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jun 21, 2022
@baileympearson baileympearson merged commit 098eb6e into main Jun 22, 2022
@baileympearson baileympearson deleted the NODE-4316/sync-latest-cmap-spec-tests branch June 22, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants