Skip to content

docs(NODE-4263): document initialize bulk op function require connection #3308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Jun 29, 2022

Description

What is changing?

API documentation calling out that initializeUnorderedBulkOp and initializeOrderedBulkOp require a connected client.

What is the motivation for this change?

These APIs rely on information obtained from the hello response from the server. Restructuring the code to run batching logic after a hello has been exchanged would be a significant amount of effort. We defer to a future project to make this possible.

NODE-4263
Follow up: https://jira.mongodb.org/browse/NODE-4360

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>

@nbbeeken nbbeeken marked this pull request as ready for review June 29, 2022 18:27
dariakp
dariakp previously approved these changes Jun 29, 2022
@dariakp dariakp added the Team Review Needs review from team label Jun 29, 2022
@dariakp dariakp merged commit 1079167 into main Jun 29, 2022
@dariakp dariakp deleted the NODE-4263/document-bulk-auto-connect branch June 29, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants