test(NODE-5237): fix flaky deadlock tests and modernize deadlock test suite #3679
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
The flaky deadlock tests are fixed. The root cause appears to be a typo in the original test, where the encryption key was inserted without
{ w: majority }
.There are a lot of cleanups in this PR too, since I was touching the files. The cleanups include:
The commits are can be reviewed one-at-a-time to easily diff the changes, although the commits are not perfect. Some changes introduced in a commit might be removed in a later commit (test name improvements for debugging and .only for example).
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript