Skip to content

ci(NODE-5312): change windows hosts to vsCurrent #3687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 26, 2023
Merged

ci(NODE-5312): change windows hosts to vsCurrent #3687

merged 2 commits into from
May 26, 2023

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented May 26, 2023 •
edited
Loading

Description

What is changing?

  • vs2019 -> vsCurrent
  • Gathered all the hosts into constants, with the intention to make a quick reference of which hosts we depend on

#3690

Is there new documentation needed for these changes?

What is the motivation for this change?

vsCurrent is a more recent OS and is better maintained

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review May 26, 2023 15:46
@durran durran self-assigned this May 26, 2023
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label May 26, 2023
@durran
Copy link
Member

durran commented May 26, 2023

All Windows tests are passing.

@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels May 26, 2023
@durran durran merged commit 63ae351 into main May 26, 2023
@durran durran deleted the NODE-5312-windows branch May 26, 2023 18:05
@nbbeeken nbbeeken mentioned this pull request May 26, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

@baileympearson baileympearson baileympearson approved these changes

Assignees

@durran durran

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nbbeeken @durran @baileympearson