Skip to content

ci(NODE-5340): properly condition publish step on outcome of build:nightly #3706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 6, 2023
Merged

ci(NODE-5340): properly condition publish step on outcome of build:nightly #3706

merged 13 commits into from
Jun 6, 2023

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Jun 5, 2023 •
edited by dariakp
Loading

Description

What is changing?

  • Properly condition the publishing on whether the script exits with success or failure.
  • Change workflow trigger to manual until we have something that can automatically consume the builds
Is there new documentation needed for these changes?

What is the motivation for this change?

Do not rely on npm duplicate version check

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 5, 2023
@dariakp dariakp self-assigned this Jun 5, 2023
@dariakp dariakp added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jun 6, 2023
@dariakp dariakp changed the title ci(NODE-5340): only run publish step if build:nightly exits with success ci(NODE-5340): properly condition publish step on outcome of build:nightly Jun 6, 2023
@dariakp dariakp merged commit 2b83ea4 into main Jun 6, 2023
@dariakp dariakp deleted the NODE-5340 branch June 6, 2023 20:19
malikj2000 pushed a commit that referenced this pull request Jun 29, 2023
@nbbeeken @malikj2000
ci(NODE-5340): properly condition publish step on outcome of build:ni…
d50bb05 
…ghtly (#3706)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariakp dariakp dariakp approved these changes

Assignees

@dariakp dariakp

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @dariakp