Skip to content

chore(NODE-5348): consolidate setup action #3724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 14, 2023
Merged

chore(NODE-5348): consolidate setup action #3724

merged 5 commits into from
Jun 14, 2023

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Jun 13, 2023 •
edited
Loading

Description

What is changing?

  • Use the shared setup action for a consitent node env, with npm deps installed
Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@dariakp dariakp self-assigned this Jun 13, 2023
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 13, 2023
@dariakp dariakp self-requested a review June 13, 2023 22:37
@dariakp dariakp merged commit 6364842 into main Jun 14, 2023
@dariakp dariakp deleted the NODE-5348-setup-gh-action branch June 14, 2023 17:35
malikj2000 pushed a commit that referenced this pull request Jun 29, 2023
@nbbeeken @malikj2000
chore(NODE-5348): consolidate setup action (#3724)
9fa05c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariakp dariakp dariakp approved these changes

Assignees

@dariakp dariakp

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @dariakp