-
Notifications
You must be signed in to change notification settings - Fork 1.8k
refactor(NODE-5471): refactor crud operations to use async/await syntax #3777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is red
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed a couple more of those slight syntax cleanups.
One thing we should also get in this PR is the BulkWriteShimOperation
. It still inherits from AbstractCallbackOperation
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identified the source of the CI redness
changed return err to throw err
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes mostly look good, but you're getting a lot of red in CI around bulk write operations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once you go through and make sure the existing suggestions about the nullish coalescing are fixed, then this should be done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still missing a couple
Description
converted all crud operations to use async/await syntax
What is changing?
all crud operations now inherit from Abstract/Command Operations instead of their callback counterparts
their execute methods also return promises
Is there new documentation needed for these changes?
None
What is the motivation for this change?
further converting the driver to async/await syntax
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript