Skip to content

ci(NODE-5668): remove custom dep tests against master and fix prose test 14 #3884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 6, 2023

Conversation

baileympearson
Copy link
Contributor

Description

What is changing?

  • 5.x only has custom dependency tests against the pinned commit
  • FLE prose test 14 has been fixed, with the same fix from #3833 (files)

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken self-assigned this Oct 5, 2023
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 5, 2023
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, before merging any idea why the CSFLE type=timestamp failed?

@nbbeeken
Copy link
Contributor

nbbeeken commented Oct 6, 2023

👍🏻 You may merge btw, I'm away from computer and mobile merging makes me nervous 😄

@baileympearson baileympearson merged commit 2ab2189 into 5.x Oct 6, 2023
@baileympearson baileympearson deleted the NODE-5668 branch October 6, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants