feat(NODE-5452): Logging Cosmos Document DB Info Message #3902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
changed the title
durran
added
the
Primary Review
durran
requested changes
Oct 31, 2023
aditi-khare-mongoDB
force-pushed
the
NODE-5452/cosmos-document-db-logging
branch
from
8df3fe9 to
ba0cc12
Compare
aditi-khare-mongoDB
force-pushed
the
NODE-5452/cosmos-document-db-logging
branch
from
ba0cc12 to
57036c0
Compare
durran
requested changes
Oct 31, 2023
durran
requested changes
Nov 2, 2023
durran
previously approved these changes
Nov 2, 2023
durran
added
Team Review
W-A-James
suggested changes
Nov 2, 2023
W-A-James
reviewed
Nov 2, 2023
W-A-James
approved these changes
Nov 2, 2023
durran
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A user connecting to a
ConnectionStringobject while using a Cosmos/DocumentDB host will not have the same client functionality as a user using a genuine host. After these changes are merged, when a user provides a non-genuine host, a info-level Client component log will be outputted to themongodbLogPath.What is changing?
If Standardized Logging is turned on and environment settings allow for Client info-level logs, when a user provides one or more CosmosDB/DocumentDB hosts, an info-level client component log(s) will be outputted to the stream provided in
mongodbLogPath.Is there new documentation needed for these changes?
Yes, it should be included in the documentation for Standardized Logging when Standardized Logging is released.
What is the motivation for this change?
To notify users when we detect a CosmosDB/DocumentDB host, since they have limited functionality in MongoClient.
Release Highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript