refactor(NODE-5764): add commandName to AbstractOperation subclasses #3934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditi-khare-mongoDB
changed the title
aditi-khare-mongoDB
changed the title
nbbeeken
added
the
Primary Review
nbbeeken
suggested changes
Nov 30, 2023
nbbeeken
suggested changes
Nov 30, 2023
nbbeeken
changed the title
Co-authored-by: Neal Beeken <[email protected]>
Co-authored-by: Neal Beeken <[email protected]>
nbbeeken
suggested changes
Dec 1, 2023
Co-authored-by: Neal Beeken <[email protected]>
Co-authored-by: Neal Beeken <[email protected]>
nbbeeken
approved these changes
Dec 1, 2023
nbbeeken
added
Team Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this change, the command name of an operation was only able to be accessed at execution time. Now, with the use of a getter in each subclass of AbstractOperation, the name of a command is able to be accessed once the operation is instantiated, or with the operation class name.
What is changing?
Allows access command name of operation once operation is instantiated, or through operation's class name.
Is there new documentation needed for these changes?
No this is an internal change, invisible to users implicitly since its within a private class.
What is the motivation for this change?
NODE-4687 (Server Selection Logging) was blocked before this change, since the AC for the ticket required command/operation name to be logged before execution of the command.
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript