Skip to content

test(NODE-3494): add observeSensitiveCommands spec tests #3941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Dec 13, 2023
Merged

test(NODE-3494): add observeSensitiveCommands spec tests #3941

merged 20 commits into from
Dec 13, 2023

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Dec 5, 2023 •
edited
Loading

Description

What is changing?

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-3494

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@alenakhineika alenakhineika marked this pull request as ready for review December 7, 2023 16:33
aditi-khare-mongoDB
aditi-khare-mongoDB suggested changes Dec 7, 2023
View reviewed changes
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Dec 7, 2023
@aditi-khare-mongoDB aditi-khare-mongoDB added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Dec 11, 2023
@aditi-khare-mongoDB aditi-khare-mongoDB requested review from nbbeeken and removed request for nbbeeken December 11, 2023 21:14
@aditi-khare-mongoDB aditi-khare-mongoDB merged commit 371aae8 into main Dec 13, 2023
@aditi-khare-mongoDB aditi-khare-mongoDB deleted the NODE-3494-support-observe-sensitive-commands branch December 13, 2023 18:45
@aditi-khare-mongoDB
Copy link
Contributor

Failing tests are flaky tests reported in NODE-5788

aditi-khare-mongoDB added a commit that referenced this pull request Dec 21, 2023
@alenakhineika @aditi-khare-mongoDB
test(NODE-3494): add observeSensitiveCommands spec tests (#3941)
a407143 
Co-authored-by: aditi-khare-mongoDB <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@aditi-khare-mongoDB aditi-khare-mongoDB aditi-khare-mongoDB approved these changes

Assignees

@aditi-khare-mongoDB aditi-khare-mongoDB

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alenakhineika @aditi-khare-mongoDB @nbbeeken