Skip to content

refactor(NODE-5742): add streaming responses support #3944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 13, 2023
Merged

refactor(NODE-5742): add streaming responses support #3944

merged 10 commits into from
Dec 13, 2023

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Dec 7, 2023

Description

What is changing?

  • Using an async iterator return responses as they arrive
  • Change command to return after reciving one response from the iterator
  • Correct tests that spy on conneciton.command
Is there new documentation needed for these changes?

No

What is the motivation for this change?

  • Support monitoring streaming protocol

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken changed the title NODE-5742-net-stream refactor(NODE-5742): add streaming responses support Dec 7, 2023
@durran durran self-assigned this Dec 11, 2023
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Dec 11, 2023
durran
durran reviewed Dec 11, 2023
View reviewed changes
durran
durran reviewed Dec 11, 2023
View reviewed changes
durran
durran requested changes Dec 11, 2023
View reviewed changes
@nbbeeken nbbeeken requested a review from durran December 11, 2023 20:39
@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Dec 12, 2023
@durran durran merged commit 70a2ef9 into main Dec 13, 2023
@durran durran deleted the NODE-5742-net-stream branch December 13, 2023 13:12
aditi-khare-mongoDB pushed a commit that referenced this pull request Dec 21, 2023
@nbbeeken @durran @aditi-khare-mongoDB
refactor(NODE-5742): add streaming responses support (#3944)
600551b 
Co-authored-by: Durran Jordan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

Assignees

@durran durran

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @durran