refactor(NODE-5914): topology.selectServer to async-await #4020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W-A-James
force-pushed
the
NODE-5914/refactor-selectServer
branch
from
03a009a to
7db2f7f
Compare
W-A-James
changed the base branch from
main
to
NODE-5915/refactor-topology-close-to-be-synchronous
W-A-James
force-pushed
the
NODE-5915/refactor-topology-close-to-be-synchronous
branch
from
c533616 to
b9ee91c
Compare
Base automatically changed from
NODE-5915/refactor-topology-close-to-be-synchronous
to
main
March 11, 2024 17:35
W-A-James
force-pushed
the
NODE-5914/refactor-selectServer
branch
from
497a29e to
e033bd5
Compare
…node-mongodb-native into NODE-5914/refactor-selectServer
nbbeeken
changed the title
nbbeeken
approved these changes
Mar 13, 2024
nbbeeken
suggested changes
Mar 13, 2024
nbbeeken
approved these changes
Mar 13, 2024
nbbeeken
suggested changes
Mar 13, 2024
nbbeeken
approved these changes
Mar 14, 2024
nbbeeken
suggested changes
Mar 14, 2024
baileympearson
requested changes
Mar 14, 2024
| @@ -883,7 +877,7 @@ function updateServers(topology: Topology, incomingServerDescription?: ServerDes | |||
| } | |||
| } | |||
|
|
|||
| function drainWaitQueue(queue: List<ServerSelectionRequest>, err?: MongoDriverError) { | |||
| function drainWaitQueue(queue: List<ServerSelectionRequest>, drainError: MongoDriverError) { | |||
There was a problem hiding this comment.
🔥 I always appreciate drive-by improvement of variable names, thanks for improving this one!
lack of attention to variable names leads to death of readability by a thousand cuts 🔪
| } | ||
| return; | ||
| } catch (err) { | ||
| // are we expecting an error? |
There was a problem hiding this comment.
tbh I thought this was intended to be a question for the reviewers 😅
I don't feel strongly but maybe making it a statement instead of a question would be a little more clear
Co-authored-by: Bailey Pearson <[email protected]>
nbbeeken
suggested changes
Mar 15, 2024
nbbeeken
approved these changes
Mar 15, 2024
baileympearson
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Topology.selectServerto async/await syntaxTopology.connectto async/await syntax and add connection lockTopology.selectServerin the driver includingIs there new documentation needed for these changes?
No
What is the motivation for this change?
NODE-5914
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript