-
Notifications
You must be signed in to change notification settings - Fork 1.8k
test(NODE-6028): skip atlas connectivity free tier 4.4 #4041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
import { LEGACY_HELLO_COMMAND, MongoClient } from '../mongodb'; | ||
|
||
/** | ||
* ATLAS_CONNECTIVITY env variable is JSON | ||
* Here's some typescript describing the shape: | ||
* | ||
* ```typescript | ||
* interface AtlasConnectivity { | ||
* [atlasDeployment: string]: [normalUri: string, srvUri: string] | ||
* } | ||
* ``` | ||
* | ||
* It should be an object with descriptive strings about the deployment type and version (i.e. sharded_cluster_3_4) | ||
* that map to a two string tuple that are the normal URI and SRV URI, order doesn't matter, but it should be that order. | ||
*/ | ||
|
||
describe('Atlas Connectivity', function () { | ||
const { ATLAS_CONNECTIVITY = '' } = process.env; | ||
if (ATLAS_CONNECTIVITY === '') throw new Error('ATLAS_CONNECTIVITY not defined in env'); | ||
|
||
const CONFIGS: Record<string, [normalUri: string, srvUri: string]> = | ||
JSON.parse(ATLAS_CONNECTIVITY); | ||
|
||
let client: MongoClient; | ||
|
||
afterEach(async function () { | ||
await client.close(); | ||
}); | ||
|
||
for (const configName of Object.keys(CONFIGS)) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. forEach -> for-of |
||
context(configName, function () { | ||
for (const connectionString of CONFIGS[configName]) { | ||
const name = connectionString.includes('mongodb+srv') ? 'mongodb+srv' : 'normal'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. indexOf -> includes |
||
|
||
beforeEach(function () { | ||
if (configName === 'replica_set_4_4_free') { | ||
const today = new Date(); | ||
// Making this April 1st so it is a monday | ||
const april1st2024 = new Date('2024-04-01'); | ||
if (today < april1st2024) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is kinda fun TBH, if the upgrade doesn't happen we'll go red again otherwise this will just become dead code and we'll start testing it again 😎 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 😎 |
||
if (this.currentTest) | ||
this.currentTest.skipReason = | ||
'TODO(NODE-6027): Un-skip replica_set_4_4_free after March 29th 2024'; | ||
this.skip(); | ||
} | ||
} | ||
}); | ||
|
||
it(name, async function () { | ||
this.timeout(40000); | ||
|
||
client = new MongoClient(connectionString); | ||
|
||
await client.connect(); | ||
await client.db('admin').command({ [LEGACY_HELLO_COMMAND]: 1 }); | ||
await client.db('test').collection('test').findOne({}); | ||
}); | ||
} | ||
}); | ||
} | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pulled the close up to an after each