Skip to content

test(NODE-5855): unskip transaction tests #4044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2024
Merged

test(NODE-5855): unskip transaction tests #4044

merged 1 commit into from
Mar 19, 2024

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Mar 18, 2024 •
edited
Loading

Description

What is changing?

  • Unskip TXN tests now that we've updated the unified spec tests
  • Unskip TXN tests on LB
  • Move session clearing of connection after checkIn

Also resolves: NODE-5931

Is there new documentation needed for these changes?

What is the motivation for this change?

  • Testing TXN

Release Highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review March 19, 2024 15:01
@baileympearson
Copy link
Contributor

The serverless test failures in this PR are unrelated.

@baileympearson baileympearson merged commit e292a79 into main Mar 19, 2024
@baileympearson baileympearson deleted the NODE-5855-unskip-txn branch March 19, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @baileympearson