refactor(NODE-6040): extract aws temporary credential acquisition logic into a standalone module #4050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
commented
Mar 21, 2024
baileympearson
changed the title
nbbeeken
added
the
Primary Review
nbbeeken
suggested changes
Mar 22, 2024
baileympearson
force-pushed
the
NODE-6040
branch
from
ee50713 to
e197b6d
Compare
nbbeeken
suggested changes
Mar 22, 2024
nbbeeken
suggested changes
Mar 22, 2024
Co-authored-by: Neal Beeken <[email protected]>
nbbeeken
approved these changes
Mar 22, 2024
aditi-khare-mongoDB
pushed a commit
that referenced
this pull request
Apr 5, 2024
…ic into a standalone module (#4050)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
In order to share AWS credential fetching logic with CSFLE, (NODE-5917), the AWS temporary credential fetching logic has been extracted from the
MongoDBAWSauth provider into a newAWSTemporaryCredentialProviderabstraction. This is purely a refactor, and all existing tests are passing.Is there new documentation needed for these changes?
What is the motivation for this change?
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript