Skip to content

refactor(NODE-3332): withTransaction uses async/await #4053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Apr 15, 2024
Merged

refactor(NODE-3332): withTransaction uses async/await #4053

merged 16 commits into from
Apr 15, 2024

Conversation

aditi-khare-mongoDB
Copy link
Contributor

@aditi-khare-mongoDB aditi-khare-mongoDB commented Mar 25, 2024 •
edited
Loading

Description

Remove callbacks for withTransaction.

What is changing?

See Description.

Is there new documentation needed for these changes?

No.

What is the motivation for this change?

Remove usage of callbacks within node driver codebase.

Release Highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken mentioned this pull request Mar 27, 2024
Merged
5 tasks
@aditi-khare-mongoDB aditi-khare-mongoDB force-pushed the NODE-3332/async-await-withTransaction branch from 5957982 to a32367f Compare April 10, 2024 20:12
@mongodb mongodb deleted a comment from evergreen-ci-prod bot Apr 10, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB marked this pull request as ready for review April 11, 2024 04:50
@aditi-khare-mongoDB aditi-khare-mongoDB changed the title refactor(NODE-3233): withTransaction uses async/await refactor(NODE-3332): withTransaction uses async/await Apr 11, 2024
@W-A-James W-A-James self-assigned this Apr 11, 2024
@W-A-James W-A-James self-requested a review April 11, 2024 13:52
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Apr 11, 2024
W-A-James
W-A-James suggested changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@W-A-James W-A-James left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far. Just a couple small changes

@aditi-khare-mongoDB aditi-khare-mongoDB force-pushed the NODE-3332/async-await-withTransaction branch from de08513 to 8d84b18 Compare April 11, 2024 20:47
W-A-James
W-A-James suggested changes Apr 12, 2024
View reviewed changes
@nbbeeken nbbeeken requested review from W-A-James and nbbeeken April 12, 2024 16:03
@aditi-khare-mongoDB aditi-khare-mongoDB force-pushed the NODE-3332/async-await-withTransaction branch from b3b72b5 to 29a8d55 Compare April 12, 2024 19:21
nbbeeken
nbbeeken suggested changes Apr 12, 2024
View reviewed changes
nbbeeken
nbbeeken suggested changes Apr 15, 2024
View reviewed changes
nbbeeken
nbbeeken suggested changes Apr 15, 2024
View reviewed changes
nbbeeken
nbbeeken suggested changes Apr 15, 2024
View reviewed changes
@W-A-James W-A-James added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Apr 15, 2024
@W-A-James W-A-James merged commit 6248174 into main Apr 15, 2024
@W-A-James W-A-James deleted the NODE-3332/async-await-withTransaction branch April 15, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@W-A-James W-A-James W-A-James approved these changes

Assignees

@W-A-James W-A-James

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aditi-khare-mongoDB @nbbeeken @W-A-James