Skip to content

chore: convert mocha hooks cjs exports to esm exports #4135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Jun 6, 2024

Description

What is changing?

  • commonjs exports can be replaced with ES syntax.
Is there new documentation needed for these changes?
  • No

What is the motivation for this change?

Proper TS conversion

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken force-pushed the chore-legacy-export-in-ts branch from c45d67f to 23d9d12 Compare July 1, 2024 19:11
@nbbeeken nbbeeken changed the title chore: convert TS cjs exports to esm exports chore: convert mocha hooks cjs exports to esm exports Jul 1, 2024
@nbbeeken nbbeeken marked this pull request as ready for review July 1, 2024 20:28
Copy link
Contributor

@aditi-khare-mongoDB aditi-khare-mongoDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice job

@aditi-khare-mongoDB aditi-khare-mongoDB self-assigned this Jul 1, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB added the Team Review Needs review from team label Jul 1, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB merged commit 8b1a510 into main Jul 2, 2024
29 checks passed
@aditi-khare-mongoDB aditi-khare-mongoDB deleted the chore-legacy-export-in-ts branch July 2, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants