Skip to content

ci(NODE-6203): fix atlas connectivity tests #4142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Jun 12, 2024

Description

What is changing?

Atlas connectivity test URIs are now obtained from aws secrets manager.

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the title fix tests ci(...): fix atlas connectivity tests Jun 12, 2024
@baileympearson baileympearson changed the title ci(...): fix atlas connectivity tests ci(NODE-6203): fix atlas connectivity tests Jun 12, 2024
@baileympearson baileympearson marked this pull request as ready for review June 12, 2024 17:18
@durran durran self-assigned this Jun 13, 2024
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 13, 2024
@baileympearson baileympearson requested a review from durran June 13, 2024 14:04
@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jun 13, 2024
@durran durran merged commit 0c687a5 into main Jun 13, 2024
24 of 29 checks passed
@durran durran deleted the no-story-atlas-tests branch June 13, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants