Skip to content

chore(NODE-6212): generate sarif reports in releases and upload sbom lite to s3 [skip-ci] #4143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 13, 2024
Merged

chore(NODE-6212): generate sarif reports in releases and upload sbom lite to s3 [skip-ci] #4143

merged 8 commits into from
Jun 13, 2024

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Jun 12, 2024 •
edited
Loading

Description

What is changing?

Sarif reports are generated and upload to s3 upon release.

Our sbom.json file is also uploaded with releases.

Example upload to s3 from main:

Screenshot 2024-06-12 at 1 13 46 PM
Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the title chore(...): generate sarif reports in releases chore(NODE-6212): generate sarif reports in releases Jun 12, 2024
@baileympearson baileympearson changed the title chore(NODE-6212): generate sarif reports in releases chore(NODE-6212): generate sarif reports in releases [skip-ci] Jun 12, 2024
@baileympearson baileympearson marked this pull request as ready for review June 12, 2024 17:39
@baileympearson baileympearson changed the title chore(NODE-6212): generate sarif reports in releases [skip-ci] chore(NODE-6212): generate sarif reports in releases and upload sbom lite to s3 [skip-ci] Jun 12, 2024
@W-A-James W-A-James self-assigned this Jun 12, 2024
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 12, 2024
@W-A-James W-A-James self-requested a review June 12, 2024 20:02
W-A-James
W-A-James reviewed Jun 12, 2024
View reviewed changes
Copy link
Contributor

@W-A-James W-A-James left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but just to confirm, is the screenshot in the description an example of this running successfully?

@baileympearson
Copy link
Contributor Author

@W-A-James Yup - the screenshot shows the sbom lite and the generated sarif report uploaded to s3.

W-A-James
W-A-James reviewed Jun 13, 2024
View reviewed changes
@baileympearson baileympearson requested a review from W-A-James June 13, 2024 16:26
@baileympearson baileympearson merged commit 35fd6b0 into main Jun 13, 2024
7 checks passed
@baileympearson baileympearson deleted the generate-sarif-reports-during-releases branch June 13, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W-A-James W-A-James W-A-James approved these changes

Assignees

@W-A-James W-A-James

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baileympearson @W-A-James