Skip to content

chore(NODE-6199): Update test/lambda/mongodb dependencies #4145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 18, 2024

Conversation

aditi-khare-mongoDB
Copy link
Contributor

Description

test/lambda/mongodb dependencies are updated

What is changing?

Update dependencies in test/lambda/mongodb dependencies.

Is there new documentation needed for these changes?

No.

What is the motivation for this change?

Keep dependencies up to date and fix "ip SSRF improper categorization in isPublic."

Release Highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 13, 2024
@nbbeeken nbbeeken self-assigned this Jun 13, 2024
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we're cleaning up the package.json file, let's make it more accurate

@aditi-khare-mongoDB aditi-khare-mongoDB force-pushed the NODE-6199/update-lambda branch 2 times, most recently from 0735d58 to 9f348f0 Compare June 13, 2024 20:24
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no changes to dependencies in here. I'm still seeing:

ip  *
Severity: high
NPM IP package incorrectly identifies some private IP addresses as public - https://github.com/advisories/GHSA-78xj-cgh5-2h22
ip SSRF improper categorization in isPublic - https://github.com/advisories/GHSA-2p57-rm9w-gvfp
fix available via `npm audit fix`
node_modules/ip

@aditi-khare-mongoDB
Copy link
Contributor Author

There's no changes to dependencies in here. I'm still seeing:

ip  *
Severity: high
NPM IP package incorrectly identifies some private IP addresses as public - https://github.com/advisories/[GHSA-78](https://jira.mongodb.org/browse/GHSA-78)xj-cgh5-2h22
ip SSRF improper categorization in isPublic - https://github.com/advisories/[GHSA-2](https://jira.mongodb.org/browse/GHSA-2)p57-rm9w-gvfp
fix available via `npm audit fix`
node_modules/ip

What command lets you see this message?

@nbbeeken nbbeeken merged commit 8d5d984 into main Jun 18, 2024
24 of 29 checks passed
@nbbeeken nbbeeken deleted the NODE-6199/update-lambda branch June 18, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants