Skip to content

test(NODE-6098): enable unified valid fail tests #4181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2024
Merged

test(NODE-6098): enable unified valid fail tests #4181

merged 2 commits into from
Jul 24, 2024

Conversation

durran
Copy link
Member

@durran durran commented Jul 22, 2024

Description

Enables the unifed test format's valid-fail tests and fixes all failures.

What is changing?

  • Syncs the valid-fail tests in the specs directory to latest.
  • Adds the necessary validation in the unified runner to pass the tests
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-6098

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran force-pushed the NODE-6098 branch 5 times, most recently from 67ce3af to c94ae67 Compare July 23, 2024 10:17
@durran durran marked this pull request as ready for review July 23, 2024 11:48
@nbbeeken nbbeeken self-assigned this Jul 23, 2024
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jul 23, 2024
@nbbeeken nbbeeken merged commit 74916f2 into main Jul 24, 2024
29 checks passed
@nbbeeken nbbeeken deleted the NODE-6098 branch July 24, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants