Skip to content

test(NODE-6323): add performance no-op baseline test #4194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 11, 2024
Merged

test(NODE-6323): add performance no-op baseline test #4194

merged 3 commits into from
Sep 11, 2024

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Aug 8, 2024 •
edited
Loading

Description

What is changing?

  • We check what returning a document "costs" to compare against our APIs
Is there new documentation needed for these changes?

What is the motivation for this change?

  • Because it should never change this would indicate if something external has changed

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken changed the title test: add performance baseline test test: add performance no-op baseline test Aug 8, 2024
@nbbeeken nbbeeken changed the title test: add performance no-op baseline test test(NODE-6323): add performance no-op baseline test Aug 13, 2024
@nbbeeken nbbeeken marked this pull request as ready for review September 10, 2024 15:21
@aditi-khare-mongoDB aditi-khare-mongoDB self-assigned this Sep 10, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Sep 10, 2024
aditi-khare-mongoDB
aditi-khare-mongoDB approved these changes Sep 11, 2024
View reviewed changes
@aditi-khare-mongoDB aditi-khare-mongoDB merged commit 8347db9 into main Sep 11, 2024
24 of 31 checks passed
@aditi-khare-mongoDB aditi-khare-mongoDB deleted the perf-baseline branch September 11, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditi-khare-mongoDB aditi-khare-mongoDB aditi-khare-mongoDB approved these changes

Assignees

@aditi-khare-mongoDB aditi-khare-mongoDB

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @aditi-khare-mongoDB