Skip to content

chore: add a 6.8 release process workflow #4215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

  • Add a workflow for releasing from 6.8
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Automated releases from 6.8

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken
Copy link
Contributor Author

nbbeeken commented Aug 30, 2024

3c3
<     branches: [5.x]
---
>     branches: [6.8]
11c11
< name: release-5x
---
> name: release-68
22c22
<           target-branch: 5.x
---
>           target-branch: 6.8
78c78
<           sarif_report_target_ref: 5.x
---
>           sarif_report_target_ref: 6.8
102c102,104
<       - run: npm publish --provenance --tag=5x
---
>         # Just picking a string to put here so that releases from this branch are not marked "latest",
>         # we should go and rm-dist-tag after this is published, no reason to keep it tagged.
>       - run: npm publish --provenance --tag=stable

The diff against release-5.x.yml

For the npm tag we could use what typescript does: "tag-for-publishing-older-releases" 😅 I think we should just delete the tag anyway so this isn't for public consumption.

Copy link
Contributor Author

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per slack convo, remove temp tag after publish

@baileympearson baileympearson merged commit 6073828 into main Sep 3, 2024
26 of 30 checks passed
@baileympearson baileympearson deleted the chore-release-6.8 branch September 3, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants