Skip to content

test(NODE-6184): sync CRUD spec tests #4263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Conversation

dariakp
Copy link
Contributor

@dariakp dariakp commented Oct 2, 2024

Description

NODE-6184 / DRIVERS-2914

What is changing?

Syncing crud/db-aggregate-write-readPreference and crud/aggregate-write-readPreference spec tests to latest spec (DRIVERS-2914).

Is there new documentation needed for these changes?

N/A

What is the motivation for this change?

Keeping up with spec test changes, avoiding potential race condition.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@dariakp dariakp marked this pull request as ready for review October 2, 2024 15:46
@W-A-James W-A-James self-requested a review October 2, 2024 15:52
@W-A-James W-A-James self-assigned this Oct 2, 2024
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 2, 2024
@W-A-James W-A-James merged commit 91f3035 into main Oct 2, 2024
27 of 30 checks passed
@W-A-James W-A-James deleted the NODE-6184/sync-crud-tests branch October 2, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants