refactor(NODE-6411): AbstractCursor accepts an external timeout context #4264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
changed the title
baileympearson
force-pushed
the
NODE-6411
branch
from
2b5a275 to
c6f4bcf
Compare
baileympearson
force-pushed
the
NODE-6411
branch
from
c6f4bcf to
64ed80f
Compare
baileympearson
changed the title
baileympearson
commented
Oct 4, 2024
| ); | ||
| } | ||
| this.cursorOptions.timeoutMode = options.timeoutMode; | ||
| if (options.tailable && this.cursorOptions.timeoutMode === CursorTimeoutMode.LIFETIME) { |
There was a problem hiding this comment.
Just a bit of cleanup, happy to revert.
W-A-James
added
the
Primary Review
W-A-James
approved these changes
Oct 4, 2024
W-A-James
added
Team Review
durran
approved these changes
Oct 4, 2024
baileympearson
added a commit
that referenced
this pull request
Oct 10, 2024
baileympearson
added a commit
that referenced
this pull request
Oct 10, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Oct 14, 2024
baileympearson
added a commit
that referenced
this pull request
Oct 21, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Nov 1, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Nov 5, 2024
dariakp
pushed a commit
that referenced
this pull request
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
The abstract cursor now accepts an external timeout. This lets operations which create cursors share their timeout contexts with the abstract cursor. This required a handful of changes:
refreshedmethodI also removed some usages of
isCSOTEnabled()by adding amaxTimeMSproperty to the TimeoutContext. We can iterate on this and removeomitMaxTimeMStoo if we want by making cursors conditionally returnnullwhen they should not set maxTimeMS, but I considered this out of scope for this PR.Is there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript