docs(NODE-6456): document CSOT pt 1 #4292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W-A-James
changed the title
|
Question: Did we want to mark the CSOT options as public or as experimental for the release? |
nbbeeken
added
the
Primary Review
nbbeeken
added
Team Review
nbbeeken
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
LGTM!
I just fixed a bit of formatting: public tags on a new line, example tags directly proceed code snippets.
I also fixed our timeoutMode enum not exported from the top-level index file, and added "type" exports to 'AnyBulkWriteOperation', 'BulkWriteOptions' which fix an outstanding erroneous issue where when loaded with ts-node those appear as "undefined" exports.
The diff on the EXPECTED_EXPORTS may look strange, I alphabetized it to make 👁️ eye inspection a bit easier.
aditi-khare-mongoDB
suggested changes
Oct 31, 2024
|
Also, let's add in the |
aditi-khare-mongoDB
suggested changes
Nov 1, 2024
aditi-khare-mongoDB
approved these changes
Nov 1, 2024
nbbeeken
added a commit
that referenced
this pull request
Nov 5, 2024
Co-authored-by: Neal Beeken <[email protected]> Co-authored-by: Aditi Khare <[email protected]>
5 tasks
dariakp
pushed a commit
that referenced
this pull request
Nov 6, 2024
Co-authored-by: Neal Beeken <[email protected]> Co-authored-by: Aditi Khare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
timeoutMSandtimeoutModeoptionsCursorTimeoutModetimeoutMSandtimeoutModepublicIs there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript