Skip to content

chore(NODE-6426): update prod dependencies #4323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

durran
Copy link
Member

@durran durran commented Nov 11, 2024

Description

Updates prod dependencies

What is changing?

Updates the prod dependencies to latest semver compatible versions.

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-6426

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

package.json Outdated
"mongodb-connection-string-url": "^3.0.0"
},
"peerDependencies": {
"@aws-sdk/credential-providers": "^3.188.0",
"@mongodb-js/zstd": "^1.1.0",
"@aws-sdk/credential-providers": "^3.687.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe, in the past, our policy about peer updates has been that changing them is a major version change.

But I know specifically the AWS SDK version selected here lined up with lambda runtime versions since the SDK is pre-installed, next time we change this we should make sure its the same as the current lambda one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch, I forgot about that. I will check against the runtime and update appropriately.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, confirmed runtime SDK is now 3.632.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if I was unclear, that was the reason in the past that we actually downgraded the AWS SDK but we should still treat AWS the same as the other peers, it cannot be upgraded until we release a major version, or we change our policy such that we can upgrade any of these.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake - I misunderstood the comment. Reverted the change.

@nbbeeken nbbeeken self-assigned this Nov 11, 2024
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Nov 11, 2024
@durran durran requested a review from nbbeeken November 11, 2024 15:54
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for viz

@durran durran requested a review from nbbeeken November 13, 2024 17:29
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is failing relating to snappy?

@durran
Copy link
Member Author

durran commented Nov 13, 2024

New PR: #4327

@durran durran closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants