-
Notifications
You must be signed in to change notification settings - Fork 1.8k
chore(NODE-6426): update prod dependencies #4323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
package.json
Outdated
"mongodb-connection-string-url": "^3.0.0" | ||
}, | ||
"peerDependencies": { | ||
"@aws-sdk/credential-providers": "^3.188.0", | ||
"@mongodb-js/zstd": "^1.1.0", | ||
"@aws-sdk/credential-providers": "^3.687.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe, in the past, our policy about peer updates has been that changing them is a major version change.
But I know specifically the AWS SDK version selected here lined up with lambda runtime versions since the SDK is pre-installed, next time we change this we should make sure its the same as the current lambda one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh good catch, I forgot about that. I will check against the runtime and update appropriately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, confirmed runtime SDK is now 3.632.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if I was unclear, that was the reason in the past that we actually downgraded the AWS SDK but we should still treat AWS the same as the other peers, it cannot be upgraded until we release a major version, or we change our policy such that we can upgrade any of these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My mistake - I misunderstood the comment. Reverted the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for viz
4294702
to
923dc0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is failing relating to snappy?
New PR: #4327 |
Description
Updates prod dependencies
What is changing?
Updates the prod dependencies to latest semver compatible versions.
Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-6426
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript