Skip to content

test(NODE-4955): sync unacknowledged write spec tests #4380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2025
Merged

test(NODE-4955): sync unacknowledged write spec tests #4380

merged 1 commit into from
Jan 28, 2025

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Jan 27, 2025 •
edited by nbbeeken
Loading

Description

What is changing?

Sync new spec tests

Is there new documentation needed for these changes?

No

What is the motivation for this change?

NODE-4955/DRIVERS-2525

Additionally syncs:

Release Highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken self-assigned this Jan 27, 2025
@nbbeeken nbbeeken self-requested a review January 27, 2025 15:52
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jan 27, 2025
nbbeeken
nbbeeken approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending what the other changes are related to

@nbbeeken nbbeeken merged commit 907aac1 into main Jan 28, 2025
24 of 30 checks passed
@nbbeeken nbbeeken deleted the NODE-4955 branch January 28, 2025 17:35
aditi-khare-mongoDB pushed a commit that referenced this pull request Jan 29, 2025
@W-A-James @aditi-khare-mongoDB
test(NODE-4955): sync unacknowledged write spec tests (#4380)
729c269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@W-A-James @nbbeeken