Skip to content

test(NODE-3151): add KMS TLS tests for client-side encryption #4485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 26, 2025
Merged

test(NODE-3151): add KMS TLS tests for client-side encryption #4485

merged 3 commits into from
Mar 26, 2025

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Mar 25, 2025 •
edited
Loading

Description

What is changing?

Add KMS TLS test: NODE-3151

Is there new documentation needed for these changes?

No

What is the motivation for this change?

Spec test for specific error messages

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken requested a review from a team as a code owner March 25, 2025 20:13
@nbbeeken nbbeeken force-pushed the NODE-3151-kms-err branch 4 times, most recently from 2b70d56 to 19cf2ee Compare March 26, 2025 14:47
@nbbeeken nbbeeken force-pushed the NODE-3151-kms-err branch from 19cf2ee to 3c258fe Compare March 26, 2025 14:47
@baileympearson baileympearson self-assigned this Mar 26, 2025
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Mar 26, 2025
baileympearson
baileympearson approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the new tests pass in CI: https://parsley.mongodb.com/evergreen/mongo_node_driver_next_rhel80_large_Node20_test_7.0_replica_set_patch_1f8e01f098ed4db6208fef482abadb8c5513c157_67e42abf5f67ce000739c31a_25_03_26_16_26_40/0/task?bookmarks=0,8960&shareLine=1106

@baileympearson baileympearson merged commit cfdb8ec into main Mar 26, 2025
30 checks passed
@baileympearson baileympearson deleted the NODE-3151-kms-err branch March 26, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

Assignees

@baileympearson baileympearson

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @baileympearson