Skip to content

fix(NODE-6962): migrate machine workflows to callbacks #4546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 2, 2025
Merged

fix(NODE-6962): migrate machine workflows to callbacks #4546

merged 6 commits into from
Jun 2, 2025

Conversation

durran
Copy link
Member

@durran durran commented Jun 1, 2025 •
edited
Loading

Description

Changes the internal machine workflows to use the internal automated callback workflow.

What is changing?

  • Migrates Azure, GCP, Test, and K8s machine workflows to callbacks.
  • Removes the now unused MachineWorkflow abstraction.
  • Updates unit tests to use the callbacks
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-6962

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran changed the title Retry OIDC auth fix: migrate machine workflows to callbacks Jun 1, 2025
@durran durran force-pushed the retry-oidc-auth branch from 2296896 to 0a0dd30 Compare June 1, 2025 19:51
@durran durran changed the title fix: migrate machine workflows to callbacks fix(NODE-6962): migrate machine workflows to callbacks Jun 2, 2025
@durran durran marked this pull request as ready for review June 2, 2025 14:23
@durran durran requested a review from a team as a code owner June 2, 2025 14:23
@baileympearson baileympearson self-assigned this Jun 2, 2025
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 2, 2025
baileympearson
baileympearson reviewed Jun 2, 2025
View reviewed changes
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small optional comment

@durran durran requested a review from baileympearson June 2, 2025 15:58
@baileympearson baileympearson merged commit bd6030f into main Jun 2, 2025
28 of 29 checks passed
@baileympearson baileympearson deleted the retry-oidc-auth branch June 2, 2025 16:28
This was referenced Jun 2, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

Assignees

@baileympearson baileympearson

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@durran @baileympearson