Modified limitRequest to allow negative limits to pass through to Mongo....

[madtimber]

... Appropriate tests added.

[christkv]

can you explain me what situation requires a negative limit ?

[madtimber]

Well, I there's not many situations that require a negative limit, but I submitted the change for two reasons:

1. Consistency. Your driver handles -1 just fine (sends Mongo a -1 and it in turns changes it to a 1) so I would think it should handle other negative numbers in the same manner.
2. Mongo handles negative limits just fine. It seems to take the absolute value of any limit coming in, so why not allow it.

The way I actually found this 'bug' is through some of my unit tests I was writing for my application. I had two test cases that were sending in negative numbers (-1 and -5) and the -1 limit was returning one document while the -5 was returning ALL documents. So theres a bit of unintended behavior there, I think.

So since Mongo handles negative limits just fine, and you allow -1 to go through, I think any negative limit should be allowed to go through and let Mongo handle it the way it wants to.

Thoughts?

[madtimber]

@ehazlett, any thoughts? (he was pairing with me on this patch)

[ehazlett]

Nope. My thoughts echo yours.

[dandv]

Speaking of negative limits, any chance to expedite documenting them?