Skip to content

DRIVERS-2449 Omit mongocryptd client #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 27, 2022
Merged

DRIVERS-2449 Omit mongocryptd client #1330

merged 4 commits into from
Oct 27, 2022

Conversation

DmitryLukyanov
Copy link

@DmitryLukyanov DmitryLukyanov commented Oct 27, 2022 •
edited
Loading

Continuation of 1308.

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded clusters, and serverless).

@DmitryLukyanov DmitryLukyanov requested a review from a team as a code owner October 27, 2022 12:46
@DmitryLukyanov DmitryLukyanov requested review from kevinAlbs and removed request for a team October 27, 2022 12:46
@kevinAlbs kevinAlbs changed the title Omit mongocryptd client DRIVERS-2449 Omit mongocryptd client Oct 27, 2022
kevinAlbs
kevinAlbs approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small wording change.

Tested in Go.

@DmitryLukyanov DmitryLukyanov merged commit 09f1d51 into mongodb:master Oct 27, 2022
@kevinAlbs kevinAlbs mentioned this pull request Oct 27, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinAlbs kevinAlbs kevinAlbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DmitryLukyanov @kevinAlbs