Parsing sinf box for enca/encv track #48
Conversation
| @@ -228,6 +228,7 @@ pub struct AudioSampleEntry { | |||
| pub samplesize: u16, | |||
| pub samplerate: u32, | |||
| pub codec_specific: AudioCodecSpecific, | |||
| pub protect_info: Option<ProtectionSchemeInfoBox>, | |||
There was a problem hiding this comment.
I don't think this abbreviation is helpful. Please call this field protection_info.
| @@ -242,6 +243,7 @@ pub struct VideoSampleEntry { | |||
| pub width: u16, | |||
| pub height: u16, | |||
| pub codec_specific: VideoCodecSpecific, | |||
| pub protect_info: Option<ProtectionSchemeInfoBox>, | |||
There was a problem hiding this comment.
'protection_info` here, likewise.
| BoxType::OpusSampleEntry => CodecType::Opus, | ||
| BoxType::ProtectedAudioSampleEntry => CodecType::EncryptedAudio, | ||
| _ => CodecType::Unknown, | ||
| }; |
There was a problem hiding this comment.
You don't mention why you're removing this. I can see this might be dead code, in that Unknown is the default and FLAC, Opus, and AAC settings were added elsewhere with the esds parsing in #38. But please confirm it is dead code.
In general, cleanup like this is better in a separate commit so it's clear why the change was made.
There was a problem hiding this comment.
Yes, it is dead code. I'll separate that to another commit next time.
| BoxType::OriginalFormatBox => { | ||
| let frma = read_frma(&mut b)?; | ||
| sinf.code_name = frma; | ||
| }, |
There was a problem hiding this comment.
I don't have the cenc spec, but 14496-12 says the OriginalFormatBox is required. Can we reject streams without one here? We don't seem to check later whether this is what we expect.
| // We only need tenc box in schi box so far. | ||
| let schi_tenc = read_schi(&mut b)?; | ||
| sinf.tenc = schi_tenc; | ||
| }, |
There was a problem hiding this comment.
Do we depend on the tenc data? If so we should probably also reject streams with a sinf without an schi.
| BoxType::OpusSampleEntry => CodecType::Opus, | ||
| BoxType::ProtectedAudioSampleEntry => CodecType::EncryptedAudio, | ||
| _ => CodecType::Unknown, | ||
| }; |
Parsing schi, tenc, sinf and frma boxes for https://bugzilla.mozilla.org/show_bug.cgi?id=1320026.