Support sass index files #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @BenjaVR, this looks great - thanks! I assume, from the example, that this will only for |
|
@mrmckeb For your own files that should already work, since this plugin is using sass without custom importer for those (as far as I understand). EDIT: I quickly tested it in a project of mine, and it looks like it is already working fine for files in your own project! |
mrmckeb
approved these changes
Feb 4, 2021
|
This has been released! Thanks again for your work on this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for index files in Sass.
With these changes the plugin supports writing
~library/folderto import the~library/folder/_index.scssfile.The 'sass-svg' library is added for testing, this is the first publicly available library I found with an
_index.scssfile.