Leave .css files un-transformed #28
Conversation
Projects using PostCSS may have enabled Sass-incompatible plugins which can result in .css files that cannot be parsed by the Sass compiler. Since PostCSS is able to extract nested selectors without any kind of transformation, we can pass in the source as-is.
| } | ||
|
|
||
| export const getFileType = (fileName: string) => | ||
| fileName.endsWith('less') ? FileTypes.less : FileTypes.scss; | ||
| fileName.endsWith('.css') |
There was a problem hiding this comment.
Rather than a nested ternary, we could use switch or if statements. If it's CSS or LESS, return those types, otherwise assume SASS.
|
Thank you for the review!
According to your snapshot tests, nesting continues to work, even with plain PostCSS. What will not work are syntax extensions that generate selectors, as this would require loading such plugins. |
|
Sorry, correct - I wrote that reply from my phone and didn't check the tests. Thanks again, I'll try to release today. |
|
This is now released. Thanks again! https://github.com/mrmckeb/typescript-plugin-css-modules/releases/tag/v1.2.1 |
Projects using PostCSS may have enabled plugins which can result in
.cssfiles that cannot be parsed by the Sass compiler. In my case, thepostcss-mixinsplugin uses a reserved Sass at-rule (@mixin) in an incompatible way, causing the transformer to fail.Since PostCSS is able to extract nested selectors without any kind of transformation, we can pass in the source as-is for plain CSS files.