Change getFilePath to use Node's path library #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous code used explicit path slash to determine the folder path of a file, which only works if the OS in question uses that type of slash. Node's path library is OS-agnostic and avoids these issues.
This reverts commit 9b118e9.
mrmckeb
approved these changes
Dec 1, 2019
|
Thanks @hellocontrol-bng, thanks for the improvement. I'll release this today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code used explicit path slash to determine the folder path of a file, which only works if the OS in question uses that type of slash. Node's path library is OS-agnostic and avoids these issues.
Also of note, the
catchhere was usingconsole.loginstead oflogger.log, which seemed wrong, but feel free to correct.Fixes #62