Skip to content

Add Sass support #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 15, 2019
Merged

Add Sass support #68

merged 5 commits into from
Dec 15, 2019

Conversation

judehunter
Copy link
Contributor

@judehunter judehunter commented Dec 13, 2019

Fixes #67

Adds support for indented sass syntax.
It's done with an indentedSyntax conditional field/option which depends on the file type (.sass for indented syntax, .scss for the one with braces) when rendering to css with the sass module.

I decided to omit some fixtures and such because it wouldn't matter whether the original file imported a .sass or .scss file.

Working autocompletion with indented sass:

image
image

@judehunter
Copy link
Contributor Author

For some reason the CI test task fails (on snapshots, it seems), though running npm test on my machine with the updated snapshots worked flawlessly. I might have screwed something up. 😕

@judehunter judehunter changed the title Add sass support Add Sass support Dec 13, 2019
@mrmckeb
Copy link
Owner

mrmckeb commented Dec 15, 2019

Hi @judehunter, I think you ran into this issue because you were using npm. You may have had a different module resolve somewhere, and that's why your snapshots are different.

I ran locally on a clean checkout of your repo - yarn && yarn test -u - and updated snapshots, and then pushed. It is all good now ;)

@mrmckeb mrmckeb merged commit 697f8cf into mrmckeb:develop Dec 15, 2019
@mrmckeb
Copy link
Owner

mrmckeb commented Dec 15, 2019

Thanks @judehunter, this is now out in v2.1.2.
https://github.com/mrmckeb/typescript-plugin-css-modules/releases/tag/v2.1.2

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocompletion doesn't work with indented sass
2 participants