build: Create tox environments using a known Cython version #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #408 +/- ##
=======================================
Coverage 88.06% 88.06%
=======================================
Files 5 5
Lines 846 846
=======================================
Hits 745 745
Misses 101 101
Continue to review full report at Codecov.
|
This change causes Tox to run the project's setup.py in a virtualenv (default path is .tox/.package). The required version of Cython is installed, rather than whatever version is installed system wide. I found that this eliminated test suite failures under CPython 3.8, that were due to me having a version of Cython that was too old to generate a compatible _cmsgpack.cpp. isolated_build was released in Tox 3.3.0, released 2018-09-11. e.g. ± tox -r .package create: /home/alex/src/msgpack-python/.tox/.package .package installdeps: setuptools >= 35.0.2, Cython~=0.29.13, pytest py27-pure recreate: /home/alex/src/msgpack-python/.tox/py27-pure py27-pure installdeps: pytest py27-pure inst: /home/alex/src/msgpack-python/.tox/.tmp/package/1/msgpack-1.0.0rc1.tar.gz ... py27-x86 create: /home/alex/src/msgpack-python/.tox/py27-x86 ERROR: InterpreterNotFound: python2.7-x86 py34-x86 create: /home/alex/src/msgpack-python/.tox/py34-x86 ERROR: InterpreterNotFound: python3.4-x86 _________________________________________ summary _________________________________________ py27-pure: commands succeeded py35-c: commands succeeded py35-pure: commands succeeded py36-c: commands succeeded py36-pure: commands succeeded py37-c: commands succeeded py37-pure: commands succeeded py38-c: commands succeeded py38-pure: commands succeeded pypy-pure: commands succeeded pypy3-pure: commands succeeded ERROR: py27-x86: InterpreterNotFound: python2.7-x86 ERROR: py34-x86: InterpreterNotFound: python3.4-x86
moreati
force-pushed
the
tox-isolated-build
branch
from
070dc11 to
0814a1c
Compare
|
This PR was slightly speculative on my part. Please feel free to reject it for any reason, or no reason - no hurt feelings. If you're unsure about anything, or you'd like a fuller explanation of what it does please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change causes Tox to run the project's setup.py in a virtualenv
(default path is .tox/.package). The required version of Cython is
installed, rather than whatever version is installed system wide. I
found that this eliminated test suite failures under CPython 3.8, that
were due to me having a version of Cython that was too old to generate a
compatible _cmsgpack.cpp.
isolated_build was released in Tox 3.3.0, released 2018-09-11.
e.g.