-
Notifications
You must be signed in to change notification settings - Fork 226
Refactor fallback' read header #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor fallback' read header #441
Conversation
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
==========================================
- Coverage 88.07% 87.80% -0.27%
==========================================
Files 5 5
Lines 847 730 -117
==========================================
- Hits 746 641 -105
+ Misses 101 89 -12
Continue to review full report at Codecov.
|
d8c9f91
to
21d6a1c
Compare
Hey @methane! |
Would you try benchmark/benchmark.py ? |
…rent available MessagePack types.
21d6a1c
to
259f343
Compare
The result with my PR barnch:
|
259f343
to
5eb8c5f
Compare
OK, would you try the benchmark with PyPy too? Note that, extension can be used by CPython when performance is needed, but fallback is used by PyPy always. |
I tried with PyPy 2.7.
with my PR branch:
|
Hi @methane! Any other checks are needed? |
I don't have time to look it in this year. Please wait months. |
Hello @methane 😀 |
bdfbee6
to
3fc7075
Compare
3fc7075
to
b02d115
Compare
I refactored the code in the
_read_header()
method of thefallback.py
file.I removed duplicated code and (hopefully) made the function more readable and maintainable.