Nicer error when packing a datetime without tzinfo #466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to pack a
datetime.datetime
object withmsgpack.packb(dt, datetime=True)
where thedt
object is missingtzinfo
, the library throws the generic errorTypeError: can not serialize 'datetime.datetime' object
.That threw me off as I thought the problem related to
datetime=True
, and didn't realise I was missingtzinfo
. This small patch outputs a more specific error message for that edge case.