Skip to content

Minor changes for kotlinization #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 26, 2020
Merged

Conversation

jarekratajski
Copy link
Contributor

  1. internal classes actually made internal
  2. removed var mutation

@codecov
Copy link

codecov bot commented Oct 25, 2020

Codecov Report

Merging #26 into master will decrease coverage by 1.73%.
The diff coverage is 76.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #26      +/-   ##
============================================
- Coverage     88.60%   86.87%   -1.74%     
  Complexity       81       81              
============================================
  Files             4        4              
  Lines           158      160       +2     
  Branches         30       30              
============================================
- Hits            140      139       -1     
- Misses            1        4       +3     
  Partials         17       17              
Impacted Files Coverage Δ Complexity Δ
...omintrospectiongenerator/internal/GeneratorImpl.kt 82.20% <57.14%> (-2.28%) 71.00 <1.00> (ø)
...chemafromintrospectiongenerator/internal/Schema.kt 100.00% <100.00%> (ø) 6.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc2fce2...53a9a8f. Read the comment docs.

output = "$output${margin}query: ${response.data.schema.queryType?.name}\n"
}
"${margin}query: ${response.data.schema.queryType?.name}\n"
} else {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. Generally, I like all the changes, outside this one (the repeated else { "" } block. Maybe StringBuilder will be better here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was more an example how to do that without variables using if expression.
Actually (actually) it also showed no tests for else branch.
But - yes surely there should be a better way to write this part of code...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But as for StringBuilder I am not allowed to use StringBuilder directly :-)

@mstachniuk mstachniuk merged commit 8adbc66 into mstachniuk:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants