[ci] Java 17 GA and 18-ea #2371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdoptOpenJDK is moved to Eclipse Adoptium. https://blog.adoptopenjdk.net/2021/08/goodbye-adoptopenjdk-hello-adoptium/ 18-ea is only available in zulu ATM
--illegal-access=permit was removed in 17 GA
|
@harawata Looks good to me, I think I'd drop jdk 16 though. A new parent release might help too if any edge case issues to address. |
|
Going to merge! |
|
Thank you, @hazendaz ! |
harawata
added a commit
to harawata/mybatis-3
that referenced
this pull request
Oct 31, 2021
Follow-up of mybatis#2371
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests that require
--illegal-access=permitare skipped on 17 and 18-ea (the option was removed in 17 GA).I added a new tag
@Tag("RequireIllegalAccess")to those tests.Regarding CGLIB, this issue tracks the 17/18 support, I think : cglib/cglib#191
I changed the
distributionbecause AdoptOpenJDK is moved to Eclipse Adoptium and 18-ea is (was?) only available in zulu.