Skip to content

[ISSUE #2509]Fix memory leak #2508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 4, 2022
Merged

[ISSUE #2509]Fix memory leak #2508

merged 2 commits into from
May 4, 2022

Conversation

Oliverwqcwrw
Copy link
Contributor

@Oliverwqcwrw Oliverwqcwrw commented Apr 2, 2022 •
edited
Loading

set(null) to remove the value might keep the reference to this pointer in the map, which can cause memory leak in some scenarios. Using remove is safer to avoid this issue.
#2509

@coveralls
Copy link

coveralls commented Apr 2, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 87.29% when pulling 2938e83 on Oliverwqcwrw:master-fix-memoryleak-4 into 586dc88 on mybatis:master.

@Oliverwqcwrw Oliverwqcwrw mentioned this pull request Apr 3, 2022
Closed
@Oliverwqcwrw Oliverwqcwrw changed the title fix-memoryleak [ISSUE #2509]fix-memoryleak Apr 3, 2022
@Oliverwqcwrw Oliverwqcwrw reopened this May 1, 2022
@Oliverwqcwrw
Copy link
Contributor Author

I turned this PR off by accident, so I turned it back on @harawata

@Oliverwqcwrw Oliverwqcwrw changed the title [ISSUE #2509]fix-memoryleak [ISSUE #2509]Fix memory leak May 1, 2022
@Oliverwqcwrw
Copy link
Contributor Author

PTAL

@harawata harawata self-assigned this May 4, 2022
@harawata harawata merged commit 8c5474b into mybatis:master May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@harawata harawata

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Oliverwqcwrw @coveralls @harawata