avoid generating NullPointerException while closing IO

[cszxyang]

minor code changes

[harawata]

I don't know...it seems to be the caller's responsibility to close the Reader/InputStream.
I would rather remove the close() calls.

@kazuki43zoo @christianpoitras
Does Spring or Guice module need these close() calls?

[awxiaoxian2020]

I don't know...it seems to be the caller's responsibility to close the Reader/InputStream. I would rather remove the close() calls.

@kazuki43zoo @christianpoitras Does Spring or Guice module need these close() calls?

Hello, @harawata
What you are talking about is the question of whether the call should exist, and the contribution he has made is worthy of recognition when the call currently already exists. Because this pattern of close() is quite common and it's safe indeed. :)
ref: the I/O tutorial in Oracle

[awxiaoxian2020]

I don't know...it seems to be the caller's responsibility to close the Reader/InputStream. I would rather remove the close() calls.

@kazuki43zoo @christianpoitras Does Spring or Guice module need these close() calls?

@harawata FYI:
in our getting-started doc, we says:

This class can be instantiated, used and thrown away. There is no need to keep it around once you've created your SqlSessionFactory. Therefore the best scope for instances of SqlSessionFactoryBuilder is method scope (i.e. a local method variable).

So the I/O stream will only use once in most cases. It is possible that the user should close the I/O stream, but it is not necessary. As a framework, it's reasonable we close the I/O stream. And MyBatis last the pattern a long time, if we romove it, there are some usage habits change for users.

[coveralls]

Coverage increased (+0.08%) to 87.302% when pulling 7ecd3f6 on cszxyang:feature_npt_avoid into 774a52d on mybatis:master.

[harawata]

Thank you, @cszxyang @awxiaoxian2020 !