Skip to content

Improve readability #2543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 6, 2022
Merged

Improve readability #2543

merged 2 commits into from
May 6, 2022

Conversation

Oliverwqcwrw
Copy link
Contributor

@Oliverwqcwrw Oliverwqcwrw commented May 1, 2022 •
edited
Loading

Fix #2547

@coveralls
Copy link

coveralls commented May 1, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 87.299% when pulling 5cfe58b on Oliverwqcwrw:master-improve-readability-11 into 8c5474b on mybatis:master.

@Oliverwqcwrw
Copy link
Contributor Author

PTAL

@hazendaz hazendaz self-assigned this May 6, 2022
@hazendaz hazendaz merged commit dacbdc8 into mybatis:master May 6, 2022
@hazendaz
Copy link
Member

hazendaz commented May 6, 2022

@Oliverwqcwrw Thank you! I agree given 'var' is a keyword from jdk 10+. I did squash this as to not bring in merge commits to the repo.

@kazuki43zoo kazuki43zoo added the polishing Improve a implementation code or doc without change in current behavior/content label May 15, 2022
@kazuki43zoo kazuki43zoo added this to the 3.5.10 milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hazendaz hazendaz

Labels
polishing Improve a implementation code or doc without change in current behavior/content
Projects
None yet
Milestone
3.5.10
Development

Successfully merging this pull request may close these issues.

Using var as a variable name is not appropriate
4 participants
@Oliverwqcwrw @coveralls @hazendaz @kazuki43zoo